sheetengine Issue Tracker Rss Feed

Commented Unassigned: Moving around in a large scene with no character just asdw keys? [7]

Freid001 — Sun, 03 Jan 2016 15:47:05 GMT

Hi,

I'm new to sheetengine, and just having a few issues rendering large scenes.

I am using the loadAndRemoveSheets() function like in the example files. I would like to be able to move around inside the world but without a character. I have created some action listeners for the asdw keys, when I use the asdw keys to move around the correct tiles are being created and destroyed. But the new tile does not position in the center of the canvas. Is it possible to get this newly drawn center tile to be displayed in the center of the canvas? I have tried sheetengine.scene.setCenter(targetp, targetpuv); but had little success.

Thanks for any help!

CODE:

$(function() {
var canvasElement = document.getElementById('maincanvas');
sheetengine.scene.init(canvasElement, {w:900,h:500});

var centertile = {x:0,y:0,z:0};

// define some basesheets
var map = [];
for (var x=-3; x<=3; x++) {
for (var y=-3; y<=3; y++) {
map.push({
centerp: { x: x * 100, y: y * 100, z: 0 },
orientation: {alphaD: 90, betaD: 0, gammaD: 0},
size: {w:100,h:100},
init: function() {
var basesheet = new sheetengine.BaseSheet(this.centerp, this.orientation, this.size);
basesheet.color = '#5D7E36';
return basesheet;
}
});
}
}

// define some sheets
for (var i=0; i<50; i++) {
(function() {
var w = Math.random()*10 + 30;
var z = w;
var c = Math.floor(Math.random()*3);
map.push({
centerp: {x:Math.random()*1000 - 500, y:Math.random()*1000 - 500, z:z},
orientation: {alphaD:c == 0 ? 90 : 0, betaD:c == 1 ? 90 : 0, gammaD:c == 2 ? 90 : 0},
size: {w:w,h:w},
init: function() {
var sheet = new sheetengine.Sheet(this.centerp, this.orientation, this.size);
sheet.context.fillStyle = c == 0 ? '#006' : c == 1 ? '#600' : '#060';
sheet.context.fillRect(0,0,w,w);
return sheet;
}
});
})();
}

sheetengine.scene.setCenter(centertile);

loadAndRemoveSheets({x:0,y:0}, centertile);

// draw initial scene
sheetengine.calc.calculateAllSheets();
sheetengine.drawing.drawScene(true);

window.onkeydown = function(e){
move( e.keyCode );
};

window.onkeyup = function(e){
move( e.keyCode );
};

function move(key) {

//var oldcentertile = $.extend( {}, centertile );

var newcentertile = {x:0,y:0,z:0}
if (key == 87) {
newcentertile.y -= 1;
} else if (key == 83) {
newcentertile.y += 1;
} else if (key == 65) {
newcentertile.x += 1;
} else if (key == 68) {
newcentertile.x -= 1;
}

loadAndRemoveSheets( centertile, newcentertile );

sheetengine.scene.setCenter(newcentertile);
sheetengine.calc.calculateChangedSheets();
sheetengine.drawing.drawScene(true);

//sheetengine.drawing.drawScene(true);

}

function loadAndRemoveSheets(oldcentertile, centertile) {
var boundary = { xmin: centertile.x * 100 - 300, xmax: centertile.x * 100 + 300, ymin: centertile.y * 100 - 300, ymax: centertile.y * 100 + 300 };

console.log( boundary );
console.log( oldcentertile );
console.log( centertile );

// remove sheets that are far
for (var i=0;i<map.length;i++) {
var sheetinfo = map[i];
if (sheetinfo.centerp.x < boundary.xmin || sheetinfo.centerp.x > boundary.xmax || sheetinfo.centerp.y < boundary.ymin || sheetinfo.centerp.y > boundary.ymax) {
if (sheetinfo.added) {
sheetinfo.sheet.destroy();
sheetinfo.added = false;
}
}
}

// add new sheets
for (var i=0;i<map.length;i++) {
var sheetinfo = map[i];
if (sheetinfo.centerp.x < boundary.xmin || sheetinfo.centerp.x > boundary.xmax || sheetinfo.centerp.y < boundary.ymin || sheetinfo.centerp.y > boundary.ymax)
continue;

if (!sheetinfo.added) {
sheetinfo.sheet = sheetinfo.init();
sheetinfo.added = true;
}
}

// translate background
sheetengine.scene.translateBackground(
{x:oldcentertile.x*100,y:oldcentertile.y*100},
{x:centertile.x*100,y:centertile.y*100}
);
}

});
Comments: move.png

Commented Unassigned: Moving around in a large scene with no character just asdw keys? [7]

Freid001 — Sun, 03 Jan 2016 15:46:39 GMT

Created Unassigned: Moving around in a large scene with no character just asdw keys? [7]

Freid001 — Sun, 03 Jan 2016 15:43:59 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

dobsonl — Thu, 04 Sep 2014 05:52:34 GMT

Hello

sometimes I get this rrror
> TypeError: currentsheet.intersectors is undefined

after I performed a change at a sheet and now want to redraw. Of course I call calculateChangedSheets() before I call the redraw method.

I don't yet know when and how it exactly occurs. I can't reproduce this error intetionally. It just sometimes occur and sometimes not at likely changes..

Is ist a bug or am I doing something wrong?

PS: A complete refresh works by the way..
Comments: Sorry, I really don't understand how this is possible. If currentsheet is undefined then it should throw an error already before that line. If intersectors is undefined it should simply skip to the next line. Try changing line 1418 to this if (currentsheet.intersectors) { instead of this if (currentsheet.intersectors != null) {

Commented Unassigned: Bug in ordering sheets [5]

dobsonl — Thu, 04 Sep 2014 05:42:54 GMT

Hello, we would like to inform you about a bug we found in the code. The problem resides in function getOrderedList(). We run into a problem if nothing has changed in an iteration of for( ;; ) loop. There is the following code fragment (lines 1259-1273):
```
if (no change) {
var zmax = -10000;
for (var i=0; i<unordered.length; i++) {
if ((i == 0) || (sheetengine.polygons[unordered[i]].data.zmax > zmax)) {
maxidx = i;
zmax = sheetengine.polygons[unordered[i]].data.zmax;
}
}
...
}
```
There are two bugs, in fact. The first one is a missing declaration of "maxidx" which is then considered global and its value persists to subsequent function calls. The other one is untreated special condition, when there is exactly one item in "unordered" and (who knows?) its data.zmax has default value of -10000. Such a condition results in an indefinite loop. Or, if maxidx declaration is present, it results in a crash in drawSheets, because orderedPolygons contains "undefined" item. We suggest to apply following change:

```
if (nochange) {
var zmax = -10000;
var maxidx = -1;
for (var i=0; i<unordered.length; i++) {
if ((i == 0) || (sheetengine.polygons[unordered[i]].data.zmax > zmax)) {
maxidx = i;
zmax = sheetengine.polygons[unordered[i]].data.zmax;
}
}

var key = 'k'+unordered[maxidx];
ordered[key] = unordered[maxidx];
//ordered[ordered.length] = unordered[maxidx];
unordered.splice(maxidx, 1);
if (unordered.length == 0)
break;
}

```
Comments: No, I haven't tested it, but looks ok to me.

Commented Unassigned: Bug in ordering sheets [5]

RohanDeshpande — Thu, 04 Sep 2014 02:04:34 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Wed, 06 Aug 2014 09:08:58 GMT

Hello

sometimes I get this rrror
> TypeError: currentsheet.intersectors is undefined

after I performed a change at a sheet and now want to redraw. Of course I call calculateChangedSheets() before I call the redraw method.

I don't yet know when and how it exactly occurs. I can't reproduce this error intetionally. It just sometimes occur and sometimes not at likely changes..

Is ist a bug or am I doing something wrong?

PS: A complete refresh works by the way..
Comments: Unfortunately I still get this error when I perform redrawings... But not every time. No clue what the problem is? TypeError: currentsheet.intersectors is undefined Stack-Trace: gatherDirtySheets@file:///path to/sheetengine.js:1419:22 calculateChangedSheets@file:///path to sheetengine.js:1575:9 Map._drawMap/<@file:///path to file.js:514:5

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Tue, 15 Jul 2014 06:26:24 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

dobsonl — Mon, 14 Jul 2014 15:17:37 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 14:42:27 GMT

Hello

sometimes I get this rrror
> TypeError: currentsheet.intersectors is undefined

after I performed a change at a sheet and now want to redraw. Of course I call calculateChangedSheets() before I call the redraw method.

I don't yet know when and how it exactly occurs. I can't reproduce this error intetionally. It just sometimes occur and sometimes not at likely changes..

Is ist a bug or am I doing something wrong?

PS: A complete refresh works by the way..
Comments: Well, I'm not sure, but it looks like it works fine if I perform some retrys in a try/catch or just wait for a milisecond with setTimeOut.. Does this make sense to you?

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 12:36:57 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 12:35:53 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 12:35:16 GMT

Commented Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

dobsonl — Mon, 14 Jul 2014 11:57:53 GMT

Edited Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 10:44:08 GMT

Edited Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 10:40:13 GMT

Created Unassigned: Bug? at calculateChangedSheets - currentsheet.intersectors is undefined [6]

Bagorolin — Mon, 14 Jul 2014 10:39:57 GMT

Commented Unassigned: Bug in ordering sheets [5]

dobsonl — Thu, 01 May 2014 18:37:10 GMT

Created Unassigned: Bug in ordering sheets [5]

radius_cz — Thu, 01 May 2014 10:40:09 GMT

Commented Unassigned: How to set light source in sheet engine [4]

dobsonl — Wed, 16 Oct 2013 07:09:48 GMT

I want to adjust light source but i don't know how to calculate its parameters?
Comments: See discussion: [https://sheetengine.codeplex.com/discussions/462403](https://sheetengine.codeplex.com/discussions/462403)